bump clap 3 -> 4 #226
Merged
bump clap 3 -> 4 #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ cargo check --features clap/deprecated
warning: use of deprecated method `clap::Arg::<'help>::required_unless`: Replaced with `Arg::required_unless_present`
--> crox\src\main.rs:47:12
|
47 | #[clap(required_unless = "dir")]
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
warning: use of deprecated method `clap::Arg::<'help>::required_unless`: Replaced with `Arg::required_unless_present`
--> crox\src\main.rs:47:12
|
47 | #[clap(required_unless = "dir")]
| ^^^^^^^^^^^^^^^
warning: use of deprecated associated function `clap::Parser::from_args`: `StructOpt::from_args` is replaced with `Parser::parse` (note the change in derives)
--> crox\src\main.rs:138:20
|
138 | let opt = Opt::from_args();
| ^^^^^^^^^
warning: use of deprecated associated function `clap::Parser::from_args`: `StructOpt::from_args` is replaced with `Parser::parse` (note the change in derives)
--> mmview\src\main.rs:17:20
|
17 | let opt = Opt::from_args();
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
warning: use of deprecated associated function `clap::Parser::from_args`: `StructOpt::from_args` is replaced with `Parser::parse` (note the change in derives)
--> stack_collapse\src\main.rs:15:20
|
15 | let opt = Opt::from_args();
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
warning: use of deprecated associated function `clap::Parser::from_args`: `StructOpt::from_args` is replaced with `Parser::parse` (note the change in derives)
--> mmedit\src\main.rs:64:20
|
64 | let opt = Opt::from_args();
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
warning: `crox` (bin "crox") generated 3 warnings
warning: `mmview` (bin "mmview") generated 1 warning
warning: `stack_collapse` (bin "stack_collapse") generated 1 warning
warning: `mmedit` (bin "mmedit") generated 1 warning
warning: use of deprecated associated function `clap::Parser::from_args`: `StructOpt::from_args` is replaced with `Parser::parse` (note the change in derives)
--> flamegraph\src\main.rs:16:20
|
16 | let opt = Opt::from_args();
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
warning: `flamegraph` (bin "flamegraph") generated 1 warning
warning: use of deprecated associated function `clap::Parser::from_args`: `StructOpt::from_args` is replaced with `Parser::parse` (note the change in derives)
--> summarize\src\main.rs:315:20
|
315 | let opt = Opt::from_args();
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
$ cargo check --features clap/deprecated warning: use of deprecated function `<Opt as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> crox\src\main.rs:47:7 | 47 | #[clap(required_unless_present = "dir")] | ^^^^ | = note: `#[warn(deprecated)]` on by default warning: use of deprecated function `<Opt as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> crox\src\main.rs:50:7 | 50 | #[clap(long = "dir")] | ^^^^ warning: use of deprecated function `<Opt as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> crox\src\main.rs:53:7 | 53 | #[clap(long = "collapse-threads")] | ^^^^ warning: use of deprecated function `<Opt as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> crox\src\main.rs:56:7 | 56 | #[clap(long = "minimum-duration")] | ^^^^ warning: use of deprecated function `<Opt as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> mmview\src\main.rs:12:7 | 12 | #[clap(short = 't', long = "thread-id")] | ^^^^ | = note: `#[warn(deprecated)]` on by default warning: `crox` (bin "crox") generated 4 warnings warning: `mmview` (bin "mmview") generated 1 warning warning: use of deprecated function `<Opt as clap::Subcommand>::augment_subcommands::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]` --> mmedit\src\main.rs:15:7 | 15 | #[clap(name = "truncate")] | ^^^^ | = note: `#[warn(deprecated)]` on by default warning: `mmedit` (bin "mmedit") generated 1 warning warning: use of deprecated function `<DiffOpt as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> summarize\src\main.rs:28:7 | 28 | #[clap(short = 'e', long = "exclude")] | ^^^^ | = note: `#[warn(deprecated)]` on by default warning: use of deprecated function `<DiffOpt as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> summarize\src\main.rs:31:7 | 31 | #[clap(long = "json")] | ^^^^ warning: use of deprecated function `<SummarizeOpt as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> summarize\src\main.rs:40:7 | 40 | #[clap(long = "json")] | ^^^^ warning: use of deprecated function `<SummarizeOpt as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> summarize\src\main.rs:44:7 | 44 | #[clap(short = 'p', long = "percent-above", default_value = "0.0")] | ^^^^ warning: use of deprecated function `<Opt as clap::Subcommand>::augment_subcommands::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]` --> summarize\src\main.rs:51:7 | 51 | #[clap(name = "aggregate")] | ^^^^ warning: use of deprecated function `<Opt as clap::Subcommand>::augment_subcommands::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]` --> summarize\src\main.rs:54:7 | 54 | #[clap(name = "diff")] | ^^^^ warning: use of deprecated function `<Opt as clap::Subcommand>::augment_subcommands::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[command(...)]` --> summarize\src\main.rs:58:7 | 58 | #[clap(name = "summarize")] | ^^^^
Can you elaborate? Do you mean the layout of the |
|
Yes, help changed and some colors, for example: to: TL\DR: |
|
Thanks for the diff, @klensy! Yes, a change there shouldn't be a problem. We don't guarantee that to have any kind of defined shape. |
michaelwoerister
approved these changes
Mar 7, 2024
|
Thanks for the PR, @klensy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks working. UI layout changed, but i guess this acceptable.